CSS enhancements to Issue Summary Table.

Review Request #2621 — Created Sept. 25, 2011 and discarded

Information

Review Board

Reviewers

CSS enhancements to Issue Summary Table.

Issue Summary Table starts collapsed.
Increased anchor width to 100%.
Added :hover coloring.
Added left-most and right-most borders.
Fixed padding on Issue Summary Table.
Removed Table if no issues are found.

Fixes:
Removed table entirely if no issues are found.
Removed table row spacing.
Added blue border color for :hover event.
Removed unnecessary CSS rules.

 
Description From Last Updated

Can the spacing between rows be removed?

daviddavid

Instead of having this comment in here, it might be nice to avoid showing the box entirely.

daviddavid
david
  1. Can you please take a screenshot and attach it to this review request?
  2. 
      
ME
MA
  1. 
      
  2. 
      
david
  1. 
      
  2. Can the spacing between rows be removed?
  3. reviewboard/templates/reviews/review_detail.html (Diff revision 1)
     
     
     
     
    Instead of having this comment in here, it might be nice to avoid showing the box entirely.
  4. 
      
ME
david
  1. I think you forgot to commit your javascript changes?
    
    Also, please fix your description to be an up-to-date summary of your changes. It's confusing to have it be an old description + a list of subsequent changes.
    1. Actually, is this request superseded by http://reviews.reviewboard.org/r/2646/ ?
    2. Yes it is. I'm not sure why the changes listed here showed up again in the other request.
    3. If review request 2646 has these changes, could you please discard this review request?
      
      Thanks,
      
      -Mike
  2. 
      
ME
Review request changed

Status: Discarded

Change Summary:

Changes repeated in 2646.
Loading...