Summary

CSS enhancements to Issue Summary Table.

Review Request #2621 — Created Sept. 25, 2011 and discarded Oct. 16, 2011, 6:26 a.m.

Information

Owner

medanat

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

CSS enhancements to Issue Summary Table.

Issue Summary Table starts collapsed.
Increased anchor width to 100%.
Added :hover coloring.
Added left-most and right-most borders.
Fixed padding on Issue Summary Table.
Removed Table if no issues are found.

Fixes:
Removed table entirely if no issues are found.
Removed table row spacing.
Added blue border color for :hover event.
Removed unnecessary CSS rules.

Testing Done

Screenshots

No issues.

CSS enhancements.

Issues

Description	From	Last Updated
Can the spacing between rows be removed?	david	Oct. 6, 2011, 3:45 a.m.
Instead of having this comment in here, it might be nice to avoid showing the box entirely.	david	Oct. 6, 2011, 3:45 a.m.

Can you please take a screenshot and attach it to this review request?

ME

medanat Sept. 26, 2011, 11:53 p.m.
```
Done.
```

Change Summary:

Added screenshots.

Screenshots:

+	No issues.
+	CSS enhancements.

CSS enhancements.
The issue has been resolved. Show all issues
```
Can the spacing between rows be removed?
```
reviewboard/templates/reviews/review_detail.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Instead of having this comment in here, it might be nice to avoid showing the box entirely.
```

Change Summary:

Added fixes suggested by David.

Description:

		CSS enhancements to Issue Summary Table.

		Issue Summary Table starts collapsed.
		Increased anchor width to 100%.
		Added :hover coloring.
		Added left-most and right-most borders.
		Fixed padding on Issue Summary Table.
~		Removed Table if no issues are found and added a relevant comment.
	~	Removed Table if no issues are found.
	+
	+	Fixes:
	+	Removed table entirely if no issues are found.
	+	Removed table row spacing.
	+	Added blue border color for :hover event.
	+	Removed unnecessary CSS rules.

Diff:

Revision 2 (+62 -21)

Show changes

	reviewboard/htdocs/media/rb/css/reviews.css
	reviewboard/templates/reviews/review_detail.html

I think you forgot to commit your javascript changes?

Also, please fix your description to be an up-to-date summary of your changes. It's confusing to have it be an old description + a list of subsequent changes.

david Oct. 7, 2011, 11:55 a.m.

Actually, is this request superseded by http://reviews.reviewboard.org/r/2646/ ?

medanat Oct. 9, 2011, 3:23 a.m.

Yes it is. I'm not sure why the changes listed here showed up again in the other request.

mike_conley Oct. 16, 2011, 6:24 a.m.

If review request 2646 has these changes, could you please discard this review request?

Thanks,

-Mike

Status: Discarded

Change Summary:

Changes repeated in 2646.