-
-
reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 1) Make sure you always have a space before the { -
reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 1) You should be able to move these two rules into ".issue table td" block below, and avoid repeating them in each of the states.
-
reviewboard/reviews/models.py (Diff revision 1) Wrap this to 80 columns. You can wrap without ugly \ characters by putting everything in parantheses: return (list(self.comments.all()) + list(self.screenshot_comments.all()) + list(self.file_attachment_comments.all())) -
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 1) For single-line docstrings, you can do it all on one line: """Turns an issue status code into a human-readable status string."""
-
-
-
reviewboard/reviews/views.py (Diff revision 1) This looks like it has tab characters. Make sure you run pep8
-
reviewboard/reviews/views.py (Diff revision 1) You can simplify this quite a bit using the static methods in BaseComment: issues['total'] += 1 issues[BaseComment.issue_status_to_string( comment.issue_status)] += 1 -
reviewboard/templates/reviews/review_detail.html (Diff revision 1) Don't include spaces between the {{s and the variable names -
Added an issue summary to a review thread.
Review Request #2617 — Created Sept. 24, 2011 and submitted
Added summary table HTML code within the review_detail template, along with relevant CSS in reviews.css.
Add an issues variable to the review_detail view response for direct access to issue statuses and counts.
Added get_all_ccoments function to the Review model in the reviews models.py in order to traverse through the comments once within the template.
Added pretty_print_status and char_limit filters to use within template.
Screenshots
| Description | From | Last Updated |
|---|---|---|
|
Make sure you always have a space before the { |
 david
|
|
|
You have another ".issue-table td" block on line 1204. |
david
|
|
|
You should be able to move these two rules into ".issue table td" block below, and avoid repeating them in … |
david
|
|
|
Wrap this to 80 columns. You can wrap without ugly \ characters by putting everything in parantheses: return (list(self.comments.all()) + … |
david
|
|
|
For single-line docstrings, you can do it all on one line: """Turns an issue status code into a human-readable status … |
david
|
|
|
Same here re: docstring. |
david
|
|
|
Remove this extra line |
david
|
|
|
This looks like it has tab characters. Make sure you run pep8 |
david
|
|
|
You can simplify this quite a bit using the static methods in BaseComment: issues['total'] += 1 issues[BaseComment.issue_status_to_string( comment.issue_status)] += 1 |
david
|
|
|
Don't include spaces between the {{s and the variable names |
david
|
|
|
Same here re: spaces |
david
|
|
|
Can you call this "pretty_print_issue_status" instead? The name "pretty_print_status" is very generic. |
david
|
|
|
Need a space between td and { |
david
|
ME
Description: |
|
|---|
-
Getting pretty close now.
-
reviewboard/htdocs/media/rb/css/reviews.css (Diff revisions 1 - 2) You have another ".issue-table td" block on line 1204.
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2) Can you call this "pretty_print_issue_status" instead? The name "pretty_print_status" is very generic.
-
Just one trivial change left.
-