Summary

Add a better error message when using --revision-range on Perforce repository

Review Request #2614 — Created Sept. 24, 2011 and submitted Sept. 24, 2011, 1:55 a.m.

Information

Owner

mike_conley

Repository

RBTools

Branch

Bugs

1495

Depends On

Reviewers

Groups

rbtools

People

Description

When using post-review in a Perforce repository, if users included the --revision-range parameter, post-review would spin out with a confusing error message.

This patch displays something a little more useful, including a link to Review Board's documentation on Perforce's range path syntax.

Testing Done

Added a quick test to ensure that using --revision-range on a Perforce repository causes us to exit out.

Issues

Description	From	Last Updated
Can you add a docstring for this?	david	Sept. 24, 2011, 12:34 a.m.

rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a docstring for this?
```

Change Summary:

Thanks for the review!  Added a docstring.

Diff:

Revision 2 (+25)

Show changes

	rbtools/clients/perforce.py
	rbtools/clients/tests.py

Ship it!

Ship It!

mike_conley Sept. 24, 2011, 1:55 a.m.
```
Thanks - committed as 2f76966736
```

Status:: Completed

rbtools/clients/tests.py (Diff revision 1)