Fix captions for newly-added screenshots and files.

Review Request #2604 — Created Sept. 22, 2011 and submitted


Review Board


Fix captions for newly-added screenshots and files.

The way that screenshot captions (and file attachment captions) worked was still
a little bit broken. When creating a screenshot via the "Add Screenshot" form,
it would set caption = draft_caption = user entered text, and everything work
work fine when the draft was published. When using the DnD upload, however, it
just attaches the item and then expects the user to change the caption in the
thumbnail. Setting the caption there will set draft_caption, but because it was
a newly added screenshot, we'd skip over it when copying draft_caption ->
caption during the publish phase.
Added new screenshots and files via the "Add" dialogs and DnD. Set captions
at various steps of the process. Published. Double checked the contents of
the database at each point.
  1. Ship It!
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (7b63c80).