Small fix to some __unicode__ methods on reviews.models

Review Request #260 — Created Feb. 19, 2008 and submitted

Information

Review Board SVN (deprecated)
409

Reviewers

Two __unicode__ methods did string interpolation using a str instance instead of a unicode instance. This ends up calling unicode(str(foo)) using the default encoding (ascii) for the interpolation arguments, raising UnicodeDecodeErrors on some cases.

 
AS
  1. 
      
  2. /trunk/reviewboard/reviews/models.py (Diff revision 1)
     
     
    There are more places that are using __unicode__ that might need to be updated as well.
    1. I looked up others models modules and did not find more cases.
  3. 
      
AS
  1. 
      
  2. 
      
david
  1. Looks good.  Committed to SVN.  Thanks!
  2. 
      
david
  1. Looks good.  Committed to SVN.  Thanks!
  2. 
      
Loading...