Sort the groups on the dashboard by name

 






 

 


  Review Request #2571
  —
  Created Sept. 1, 2011 and discarded 

 


















 

  

   Information

  





 
 

  dstanek
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When you have anything more than a few groups to watch having them out of order is very painful. This patch will make the groups in the dashboard appear in order.

 








  


 
 

  
Did some manual testing using Django 1.3.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    A better way to do this would be to sort this at SQL query time in reviews/datagrids.py.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Actually that wouldn't work. The code in datagrids.py just populates a dictionary, which doesn't give us any sort info. This change looks good to me.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Can't we use Django's SortedDict to preserve that sort info, and sort in SQL?
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Sure, I can do that. Discarding this change...
      
 
      

      4. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 DS





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...