Summary

Sort the groups on the dashboard by name

Review Request #2571 — Created Sept. 1, 2011 and discarded Oct. 8, 2011, 4:52 p.m.

Information

Owner

dstanek

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When you have anything more than a few groups to watch having them out of order is very painful. This patch will make the groups in the dashboard appear in order.

Testing Done

Did some manual testing using Django 1.3.

Expand All
Collapse All

A better way to do this would be to sort this at SQL query time in reviews/datagrids.py.

david Oct. 8, 2011, 4:43 p.m.

Actually that wouldn't work. The code in datagrids.py just populates a dictionary, which doesn't give us any sort info. This change looks good to me.

chipx86 Oct. 8, 2011, 4:46 p.m.

Can't we use Django's SortedDict to preserve that sort info, and sort in SQL?

david Oct. 8, 2011, 4:52 p.m.

Sure, I can do that. Discarding this change...

Status:: Discarded