Summary

Fix a compatibility issue with Perforce on Python 2.4.

Review Request #2498 — Created July 28, 2011 and submitted July 29, 2011, 8:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

2195

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix a compatibility issue with Perforce on Python 2.4.

The finally: keyword isn't supported in Python 2.4. Rework an exception
to not need it.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
This now won't call _disconnect() in the case of an exception other than P4Exception. This should probably also catch Exception, …	david	July 28, 2011, 4:30 p.m.

reviewboard/scmtools/perforce.py (Diff revision 1)

The issue has been resolved. Show all issues

This now won't call _disconnect() in the case of an exception other than P4Exception. This should probably also catch Exception, _disconnect(), and then re-throw it.

Diff:

Revision 2 (+6 -3)

Show changes

reviewboard/scmtools/perforce.py

Ship it!

One final change: can you add a comment that this should ideally be using "with"?

Status:: Completed
Change Summary:: Committed to master (279747c)