Summary

Fix an issue that editing an reply lead to multiple replies

Review Request #2474 — Created July 12, 2011 and discarded July 28, 2011, 11:34 p.m.

Information

Owner

hongbin

Repository

Review Board

Branch

Bugs

2154

Depends On

Reviewers

Groups

reviewboard

People

Description

Not sure whether it is the right way to fix. Logically, user should not reply to the same comment again and again. If it is, then the latest reply should override the previous reply.

Testing Done

Manually and unit tested.

Files

I'm not sure this is correct. Can you give me the exact repro case? If we're talking new comments within the same draft, yes, there should be only one. Deleting is probably not what we want though. Rather, we need to fetch the right comment and update it, which is likely going to be partly on the JavaScript side of things.

hongbin July 17, 2011, 11:53 p.m.

Hi Christian.
This bug can be reproduced by reply -> OK -> edit -> OK -> published. Then multiple replies showed up. You can find the detail in the bug tracker. And yes, I am talking new comments within the same draft. I can do it in front end if you want, but possible much more code.

Status: Discarded

Change Summary:

Fixed in http://reviews.reviewboard.org/r/2499/