Fix star/unstar issue plus counters, add unit test
Review Request #2472 — Created July 11, 2011 and submitted
| Information | |
|---|---|
| cae | |
| Review Board | |
| 2051 | |
| Reviewers | |
| reviewboard | |
* Fixed unstar_review_request to behave more like star_review_request * Fixed star/unstar review requests to save at the end of the functions * Added unit test for proper star/unstar behavior and counter checking
| Description | From | Last Updated |
|---|---|---|
|
Blank line between these (Python modules go: 1) System, 2) Third party, 3) Current project)) |
 chipx86
|
|
|
Remove the excess whitespace. |
chipx86
|
|
|
Can you mention "review request counts"? There are other types of counts out there. |
chipx86
|
|
|
No need for \ The profile1.starred_... should align with the "review_request in" |
chipx86
|
|
|
Same. |
chipx86
|
CA
Status: Re-opened
Summary: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||
Groups: |
|
||||||||||||
Diff: |
Revision 1 (+42 -12) |
CA
Description: |
|
|---|
-
-
reviewboard/accounts/tests.py (Diff revision 1) Blank line between these (Python modules go: 1) System, 2) Third party, 3) Current project))
-
-
reviewboard/accounts/tests.py (Diff revision 1) Can you mention "review request counts"? There are other types of counts out there.
-
reviewboard/accounts/tests.py (Diff revision 1) No need for \ The profile1.starred_... should align with the "review_request in"
-