• 
      

    Fix star/unstar issue plus counters, add unit test

    Review Request #2472 — Created July 11, 2011 and submitted

    Information

    cae
    Review Board

    Reviewers

    * Fixed unstar_review_request to behave more like star_review_request
    * Fixed star/unstar review requests to save at the end of the functions
    * Added unit test for proper star/unstar behavior and counter checking
    
     
    Description From Last Updated

    Blank line between these (Python modules go: 1) System, 2) Third party, 3) Current project))

    chipx86chipx86

    Remove the excess whitespace.

    chipx86chipx86

    Can you mention "review request counts"? There are other types of counts out there.

    chipx86chipx86

    No need for \ The profile1.starred_... should align with the "review_request in"

    chipx86chipx86

    Same.

    chipx86chipx86
    CA
    CA
    CA
    CA
    CA
    CA
    CA
    chipx86
    1. 
        
    2. reviewboard/accounts/tests.py (Diff revision 1)
       
       
       
      Show all issues
      Blank line between these (Python modules go: 1) System, 2) Third party, 3) Current project))
    3. reviewboard/accounts/tests.py (Diff revision 1)
       
       
      Show all issues
      Remove the excess whitespace.
    4. reviewboard/accounts/tests.py (Diff revision 1)
       
       
      Show all issues
      Can you mention "review request counts"? There are other types of counts out there.
    5. reviewboard/accounts/tests.py (Diff revision 1)
       
       
       
      Show all issues
      No need for \
      
      The profile1.starred_... should align with the "review_request in"
    6. reviewboard/accounts/tests.py (Diff revision 1)
       
       
       
      Show all issues
      Same.
    7. 
        
    chipx86
    1. Ship It!
    2. 
        
    CA
    Review request changed
    Status:
    Completed
    Change Summary:
    Committed to master (8fcd7b6)