Fixed an issue that close description didn't show to other users

 






 

 


  Review Request #2463
  —
  Created July 10, 2011 and submitted 

 


















 

  

   Information

  





 
 

  hongbin
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Now, non-empty close descriptions will show up regardless of users' permission. However, it will become editable if users have permissions to do that.

This change should go with review 2461.

 








  


 
 

  
Manually tested. Logined as users with different permissions and anonymous users. The close description showed correctly.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks good. I made one change, which was just to remove the "Reason it's..." labels when it's not the author. I think the description, if it's there, along with the context of the banner will be enough.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 HO





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Committed to master (e25a1d0)





 


 










  

 









     

    

   

  

  

   
   Loading...