SCM clients refactoring first step, tests for GitClient
Review Request #2452 — Created July 6, 2011 and submitted
This patch starts series of patches intended to refactor existing SCM clients and cover them with tests. The current patch does small cleanups in GitClient and adapts postreview GitClientTests to it.
rbtools/clients/test.py
| Description | From | Last Updated |
|---|---|---|
|
Shouldn't this be ['svn', 'find-rev'] ? |
 chipx86
|
|
|
['apply', '--check'] ? |
chipx86
|
|
|
Update to use rbtools.clients. |
chipx86
|
|
|
Two blank lines. |
chipx86
|
|
|
No blank line. |
chipx86
|
|
|
Probably should do the in_path test before creating a GitClient(). |
chipx86
|
|
|
Should use # and not """ for commenting out. """ is for long strings or documentation. Same with other instances … |
chipx86
|
-
-
rbtools/clients/git.py (Diff revision 1) You can simplify this to: return self.util.execute([GIT_CMD] + params, **kwargs)
-
-
-
-
-
-
rbtools/clients/test.py (Diff revision 1) Probably should do the in_path test before creating a GitClient().
-
rbtools/clients/test.py (Diff revision 1) Should use # and not """ for commenting out. """ is for long strings or documentation. Same with other instances in this file. If a test can't be implemented today due to work still needing to be done, just comment out the whole test function with a little note. Don't bother to implement and raise SkipTest. Ideally, a SkipTest should be fixable by fulfilling a dependency.
MB
Change Summary:
Met review notes. "rbtools.clients.client" wasn't updated because I'd like to do this work within another patch which would merge 'api' and 'master'.
Diff: |
Revision 2 (+52 -62) |
|---|