Summary

SCM clients refactoring first step, tests for GitClient

Review Request #2452 — Created July 6, 2011 and submitted Aug. 21, 2011, 8:19 a.m.

Information

Owner

mbait

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This patch starts series of patches intended to refactor existing SCM clients and cover them with tests. The current patch does small cleanups in GitClient and adapts postreview GitClientTests to it.

Testing Done

rbtools/clients/test.py

Issues

Description	From	Last Updated
Shouldn't this be ['svn', 'find-rev'] ?	chipx86	July 8, 2011, 5:28 p.m.
['apply', '--check'] ?	chipx86	July 8, 2011, 5:28 p.m.
Update to use rbtools.clients.	chipx86	July 8, 2011, 5:28 p.m.
Two blank lines.	chipx86	July 8, 2011, 5:28 p.m.
No blank line.	chipx86	July 8, 2011, 5:28 p.m.
Probably should do the in_path test before creating a GitClient().	chipx86	July 8, 2011, 5:29 p.m.
Should use # and not """ for commenting out. """ is for long strings or documentation. Same with other instances …	chipx86	July 8, 2011, 5:30 p.m.

Can you sync this with the latest SCMClient changes?

Also, testutils should probably be in rbtools.utils.

Fix it!

rbtools/clients/git.py (Diff revision 1)

You can simplify this to:

return self.util.execute([GIT_CMD] + params, **kwargs)

rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Shouldn't this be ['svn', 'find-rev'] ?
```
rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
['apply', '--check'] ?
```
rbtools/clients/test.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Update to use rbtools.clients.
```
rbtools/clients/test.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Two blank lines.
```
rbtools/clients/test.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No blank line.
```
rbtools/clients/test.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Probably should do the in_path test before creating a GitClient().
```

rbtools/clients/test.py (Diff revision 1)

An issue was opened. Show all issues

Should use # and not """ for commenting out. """ is for long strings or documentation.

Same with other instances in this file.

If a test can't be implemented today due to work still needing to be done, just comment out the whole test function with a little note. Don't bother to implement and raise SkipTest. Ideally, a SkipTest should be fixable by fulfilling a dependency.

Change Summary:

Met review notes. "rbtools.clients.client" wasn't updated because I'd like to do this work within another patch which would merge 'api' and 'master'.

Diff:

Revision 2 (+52 -62)

Show changes

	rbtools/clients/git.py
	rbtools/clients/test.py

Diff:

Revision 3 (+926 -951)

Show changes

	rbtools/tests.py
	rbtools/clients/tests.py
	rbtools/utils/testbase.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Submitted to master (18c3d5d) and api.