fixing what I believe are a few more refactoring errors/leftovers
Review Request #245 — Created Feb. 13, 2008 and submitted — Latest diff uploaded
I ran pychecker against the post-review and found a few other pieces that look to be refactoring errors. I've cleaned them up in this checkin. Specifically fixed issues with accessing a non-existant "filename" in the config parser and properly passing the variable to open a browser
before: ------- Processing post-review... Warnings... post-review.py:4: Imported module (httplib) not used post-review.py:6: Imported module (mimetypes) not used post-review.py:122: (id) shadows builtin post-review.py:143: Local variable (rsp) not used post-review.py:159: Local variable (rsp) not used post-review.py:334: No global (filename) found post-review.py:386: Parameter (changenum) not used post-review.py:423: Parameter (files) not used post-review.py:835: Local variable (review_url) not used post-review.py:838: Comparisons with True are not necessary and may not work as expected post-review.py:843: No global (reviewUrl) found after: ------ Processing post-review... Warnings... post-review.py:4: Imported module (httplib) not used post-review.py:6: Imported module (mimetypes) not used post-review.py:122: (id) shadows builtin post-review.py:143: Local variable (rsp) not used post-review.py:159: Local variable (rsp) not used post-review.py:386: Parameter (changenum) not used post-review.py:423: Parameter (files) not used post-review.py:838: Comparisons with True are not necessary and may not work as expected