Summary

fixing what I believe are a few more refactoring errors/leftovers

Review Request #245 — Created Feb. 13, 2008 and submitted

Information

Owner

heckj

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

I ran pychecker against the post-review and found a few other pieces that look to be refactoring errors. I've cleaned them up in this checkin. Specifically fixed issues with accessing a non-existant "filename" in the config parser and properly passing the variable to open a browser

Testing Done

before:
-------
Processing post-review...

Warnings...

post-review.py:4: Imported module (httplib) not used
post-review.py:6: Imported module (mimetypes) not used
post-review.py:122: (id) shadows builtin
post-review.py:143: Local variable (rsp) not used
post-review.py:159: Local variable (rsp) not used
post-review.py:334: No global (filename) found
post-review.py:386: Parameter (changenum) not used
post-review.py:423: Parameter (files) not used
post-review.py:835: Local variable (review_url) not used
post-review.py:838: Comparisons with True are not necessary and may not work as expected
post-review.py:843: No global (reviewUrl) found

after:
------
Processing post-review...

Warnings...

post-review.py:4: Imported module (httplib) not used
post-review.py:6: Imported module (mimetypes) not used
post-review.py:122: (id) shadows builtin
post-review.py:143: Local variable (rsp) not used
post-review.py:159: Local variable (rsp) not used
post-review.py:386: Parameter (changenum) not used
post-review.py:423: Parameter (files) not used
post-review.py:838: Comparisons with True are not necessary and may not work as expected

Ship it!

Thanks! Committed to SVN. (r1171)

heckj Feb. 15, 2008, 2:29 a.m.

I'm really sorry to be a pain, but what was committed in revision 1171 isn't what I submitted.

The 1171 update looks good to me, but it just isn't my update. Since there have been some updates, I'm resubmitting an updated diff here...

chipx86 Feb. 15, 2008, 6:59 a.m.

Now I'm really confused.

So I applied your patch file and then cleaned up the other things mentioned in pychecker, then submitted. But you're right, your patch isn't in here now. I was taking care of some other patches at the same time and I wonder if I stupidly reverted your change before putting in the other fixes to this file.

Anyhow, committing again. Sorry about that.