Summary

Fixed an auto-completer issue, which it didn't match extra parameter correctly

Review Request #2447 — Created June 30, 2011 and discarded Feb. 3, 2014, 4:56 p.m.

Information

Owner

hongbin

Repository

Review Board

Branch

Bugs

2107

Depends On

Reviewers

Groups

reviewboard

People

Description

By default, auto-completer used cache to match user's typed query. In general, it is good for performance. However, when extra parameter is used, auto-completer should talk to server to get the right result set, which means we should not use cache to match subset of query.

Testing Done

Manually tested.

reviewboard/htdocs/media/rb/js/reviews.js (Diff revision 1)

decrease server load and increase performance.

(delete two "s"es)

reviewboard/htdocs/media/rb/js/reviews.js (Diff revision 1)

Your comment doesn't seem to match your usage of this option: both call sites use extraParams, yet one call site sets this option true, and the other false.

hongbin July 3, 2011, 4:23 a.m.

Thanks for review. Here is my thought. The true option have been used for a long time and nobody complaint except this bug. I prefer to leave the other one as is even it is technically incorrect. The reason is the false option is a serious performance hit, since every keydown will trigger an database processing in the backend.

jjlee July 3, 2011, 4:28 a.m.

Maybe update the comment(s) to explain that?

HO

hongbin July 3, 2011, 5:22 a.m.
```
Yes, definitely.
```

Status:: Discarded