-
-
-
reviewboard/scmtools/svn.py (Diff revision 1) What kind of path is this? I guess it's an abstract POSIX-style path? Or is it defined in rb as a URI path component or something? Either way, I guess // is a valid path. I'm asking because if it's an invalid path rather than just a de-normalized path, the bug should presumably be fixed elsewhere. If // is a valid path, then why not "///" (etc.)? If the code wants a path normalized such that double slashes don't appear, probably want to do path = posixpath.normpath(path) right at the top of this function. Test case would be nice here, too :-)
Fixes bug 2134
Review Request #2441 — Created June 29, 2011 and submitted
Information | |
---|---|
NateBragg | |
Review Board | |
Reviewers | |
reviewboard | |
Fixes bug 2134 diffs were being created for files where the area surrounding keywords had changed, and the keywords were not being collapsed. This was happening for two reasons: * it couldn't understand paths with two leading slashes * `svn propget svn:keywords` can return strings with non-space delimiters Also, I had submitted this previously as a pull request on github - sorry about that. I couldn't find your policy for contributions, so I just figured that was it. You might want to make that a bit more visible.
Using reviewboard 1.5.5 on a Windows 7 server using Apache+mod_wsgi running on python 2.7 with subversion 1.6.15 (if that matters)
JJ
NA
-
-
reviewboard/scmtools/svn.py (Diff revision 1) I don't know if it's the intended behavior, but the result of `posixpath.normpath` on my system (with is python 2.7.1, windows XP): >>> posixpath.normpath("//something/something/else/") '//something/something/else' So, that doesn't actually seem to correct that problem...