post-review and webapi: Allow specifying a submitter different that the currently logged user

Review Request #244 — Created Feb. 12, 2008 and submitted — Latest diff uploaded

Information

Review Board SVN (deprecated)
405

Reviewers

This is very useful for post-commit hooks, where the "currently logged user" will be one with the right permissions to specify the changeset committer as the review request submitter.

It is based on http://reviews.review-board.org/r/210/, but I left out everything not strictly needed for this use case (except a few imports missing on json.py). Also used django permission system.

Update 2008-02-14: Changes according to Christian's review, diff against current HEAD.

Update 2008-02-14 (Again): is_mutable_by is now used on reviews.views.publish (otherwise the -p flag of post-review will not work) and reviews.views.setstatus (for consistency). Also actually made a change I unintentionally ignored before and adjusted a line to respect the 80 characters limit.

 
    Loading...