Add HTTP Basic Auth support to the git raw-file method.

 






 

 


  Review Request #2420
  —
  Created June 23, 2011 and submitted

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Add HTTP Basic Auth support to the git raw-file method.

This is a simple change which adds support for HTTP Basic Auth to the Git
SCMTool, for use with the raw-file URL.

 








  


 
 

  
Tested this against a server running trac behind basic auth. Trac support
is another bag of orcas but it's not getting HTTP 401s anymore.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Awesome :) One question, but happy otherwise.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/scmtools/git.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    





    
    I don't recall, do you have to close f? Looks like we didn't before but I can never remember. Maybe we're leaking.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Nothing I can find seems to do so. It's not a real file, just file-like.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 









     

    

   

  

  

   
   Loading...