Fix new-user notification on django < 1.3

 






 

 


  Review Request #2404
  —
  Created June 19, 2011 and submitted

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Fix new-user notification on django < 1.3

The new-user notification email sent both text and html versions of the email,
but the mail_admins function didn't get an html parameter until 1.3. Since we
don't yet require this, we shouldn't rely on it.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    We could just use the custom mail class we have and stick the admins in the To list. mail_admins() basically does that anyway, but with the built-in class. That way, we get HTML on 1.2 and 1.3.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  








 
Change Summary:

 
Use SpiffyEmailMessage instead.





 



  

   
Diff:

   
    
 Revision 2 (+6 -7)
Show changes
 
    reviewboard/notifications/email.py 
    reviewboard/notifications/tests.py 
 

   		
  



 










  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Think this is fine, but I'm confused about one change.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/notifications/tests.py
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    





    
    What changed here?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      The to email was now a tuple (name, address) instead of just the address.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Ah okay, ship it.
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 









     

    

   

  

  

   
   Loading...