Reduce the display of user information in user page, info box, and webapi.

Review Request #2396 — Created June 12, 2011 and submitted

hongbin
Review Board
2127
reviewboard
Reduce the display of user information in user page, info box, and webapi.

* Added support for private profile, which means users can set their profile as private so that their names, emails and ids will not be visible from normal users, but staff users can still see that.
* The user information mentioned above is not visible from anonymous users even it is a public profile.
Unit and manually tested.
david
  1. 
      
  2. If the default in the model is False (which I think is good), then initial should be False here.
  3. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Add a space between "users" and "(if"
  4. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Add another space before this line to align it with its block.
  5. reviewboard/reviews/views.py (Diff revision 1)
     
     
     
     
    Can you switch the truthiness of this and call it "show_profile" instead?
    
    It reads a little better in the templates as "if show_profile" instead of "if not hide_profile"
  6. 
      
HO
Review request changed
david
  1. Looks good. Pushed to master as 11bbf32. Thanks!
  2. 
      
Loading...