Reduce the display of user information in user page, info box, and webapi.

 






 

 


  Review Request #2396
  —
  Created June 12, 2011 and submitted

 


















 

  

   Information

  





 
 

  hongbin
 









 
 

  Review Board
 









 
 

  
 









 
 

  2127
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Reduce the display of user information in user page, info box, and webapi.

* Added support for private profile, which means users can set their profile as private so that their names, emails and ids will not be visible from normal users, but staff users can still see that.
* The user information mentioned above is not visible from anonymous users even it is a public profile.

 








  


 
 

  
Unit and manually tested.

 







 









 





  








 









 






  

 








 














 





 

  

   




david




   

   





  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/accounts/evolutions/profile_is_private.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    If the default in the model is False (which I think is good), then initial should be False here.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/reviews/views.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    Add a space between "users" and "(if"
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/reviews/views.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    Add another space before this line to align it with its block.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/reviews/views.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    





    
    Can you switch the truthiness of this and call it "show_profile" instead?

It reads a little better in the templates as "if show_profile" instead of "if not hide_profile"
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  6. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 




  

 
















 



 

  

   





 HO





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  









  

   

    Change Summary:
   

   

    
Modified as David suggested. Thanks.

   

  








  

   

    Diff:
   

   

    
 Revision 2 (+107 -7)
Show changes
 
    reviewboard/accounts/forms.py 
    reviewboard/accounts/models.py 
    reviewboard/accounts/views.py 
    reviewboard/accounts/evolutions/profile_is_private.py 
    reviewboard/accounts/fixtures/test_users.json 
    reviewboard/reviews/views.py 
    reviewboard/templates/accounts/prefs.html 
    reviewboard/templates/accounts/user_infobox.html 
  3 more
 

   

  












  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks good. Pushed to master as 11bbf32. Thanks!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.