Summary

ClearCase Python 2.4 incompatibility hotfix

Review Request #2395 — Created June 11, 2011 and submitted Sept. 5, 2011, 2:23 p.m.

Information

Owner

jan.koprowski

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Do not use os.path.relpath function if python version does not have one.
Ready to commit!

Testing Done

Need work

Issues

Description	From	Last Updated
This should describe what the function does and why. You could include the comment text below as the function doc …	chipx86	Sept. 4, 2011, 3:10 a.m.
Blank line between these.	chipx86	Sept. 4, 2011, 3:10 a.m.

Ship it!

```
Thanks. Committed to master (6eb15d0)
```

Status: Re-opened

Change Summary:

Fix problem in both places where relpath function was used not only in one place.

Need testing.

Diff:

Revision 2 (+15 -14)

Show changes

reviewboard/scmtools/clearcase.py

Ship it!

```
Ship It!
```

Description:

~		Do not use os.path.relpath function if python version does not have one.
	~	Do not use os.path.relpath function if python version does not have one.
	+	Ready to commit!

Testing Done:

~		Waiting for testing
	~	Thanks for testing for Gyanesh Singh!

reviewboard/scmtools/clearcase.py (Diff revision 2)

Hi Jan,

The first param needs to be the self? Right? It gives me a problem.

reviewboard/scmtools/clearcase.py (Diff revision 2)

Related to comment 1. For me, it's giving a problem. Something like, relpath() takes only two args, whereas at this line we are passing 3. self is an implicit argument, I believe.

reviewboard/scmtools/clearcase.py (Diff revision 2)

Again, this gives me a problem. self.relpath() to be resolved to which function/method? relpath() is defined there in ClearCaseTool class, whereas at this line #, we want it in ClearCaseDiffParser

Testing Done:

~		Thanks for testing for Gyanesh Singh!
	~	Need work

Thank You!

I will fix this issues soon.

Change Summary:

Fix raised issues.

Diff:

Revision 3 (+16 -14)

Show changes

reviewboard/scmtools/clearcase.py

Ship it!

Ship It!

gyanesh.singh Sept. 4, 2011, 12:15 a.m.

Hi Jan,

I have tested the patch. And it works like a charm. :-) No comments from my side. Works absolutely fine. Good to go. No comments from my side.

BR,
Gyanesh

Fix it!

reviewboard/scmtools/clearcase.py (Diff revision 3)

An issue was opened. Show all issues

This should describe what the function does and why.

You could include the comment text below as the function doc body.

reviewboard/scmtools/clearcase.py (Diff revision 3)
An issue was opened. Show all issues
```
Blank line between these.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Committed to release-1.6.x (dd97872)