ClearCase Python 2.4 incompatibility hotfix

Review Request #2395 — Created June 11, 2011 and submitted

Information

Review Board

Reviewers

Do not use os.path.relpath function if python version does not have one.
Ready to commit!
Need work
Description From Last Updated

This should describe what the function does and why. You could include the comment text below as the function doc …

chipx86chipx86

Blank line between these.

chipx86chipx86
chipx86
  1. Thanks. Committed to master (6eb15d0)
  2. 
      
jan.koprowski
jan.koprowski
jan.koprowski
  1. Ship It!
  2. 
      
jan.koprowski
GY
  1. 
      
  2. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
    Hi Jan,
    
    The first param needs to be the self? Right? It gives me a problem.
  3. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
    Related to comment 1. For me, it's giving a problem. Something like, relpath() takes only two args, whereas at this line we are passing 3. self is an implicit argument, I believe.
  4. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
    Again, this gives me a problem. self.relpath() to be resolved to which function/method? relpath() is defined there in ClearCaseTool class, whereas at this line #, we want it in ClearCaseDiffParser
  5. 
      
jan.koprowski
jan.koprowski
  1. Thank You!
    
    I will fix this issues soon.
  2. 
      
jan.koprowski
GY
  1. Ship It!
    1. Hi Jan,
      
      I have tested the patch. And it works like a charm. :-) No comments from my side. Works absolutely fine. Good to go. No comments from my side.
      
      BR,
      Gyanesh
  2. 
      
chipx86
  1. 
      
  2. reviewboard/scmtools/clearcase.py (Diff revision 3)
     
     
     
    Show all issues
    This should describe what the function does and why.
    
    You could include the comment text below as the function doc body.
  3. reviewboard/scmtools/clearcase.py (Diff revision 3)
     
     
     
    Show all issues
    Blank line between these.
  4. 
      
chipx86
  1. Ship It!
  2. 
      
jan.koprowski
Review request changed
Status:
Completed
Change Summary:
Committed to release-1.6.x (dd97872)