Improve the look and feel of file attachments.

Review Request #2372 — Created May 18, 2011 and submitted

Review Board
Improve the look and feel of file attachments.

File attachments have a look more similar to screenshots, with an icon and
"Add Comment" buttons.

This new UI is used both when adding a new file or when loading existing
files as part of the page.

This does not hook up the comment dialog. That's coming in another change.
We may also want to revisit part of the UI for this, but for now it works.
Uploaded files of different type and saw the new UI. The same UI loaded
when reloading the page.

Deleting the entry worked properly. So did renaming the text.

  2. Can you put the image inside the link? I could see people wanting to click on it, given its location.
Review request changed
  1. The image doesn't have a border around it now, right?
    1. What border?
    2. The one that images often have when they're inside an <a>. I'll assume that's a "no".
    3. Oh, that's a no. They're actually disabled globally.