Summary

Improve the look and feel of file attachments.

Review Request #2372 — Created May 18, 2011 and submitted

Information

Owner

chipx86

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Improve the look and feel of file attachments.

File attachments have a look more similar to screenshots, with an icon and
"Add Comment" buttons.

This new UI is used both when adding a new file or when loading existing
files as part of the page.

This does not hook up the comment dialog. That's coming in another change.
We may also want to revisit part of the UI for this, but for now it works.

Testing Done

Uploaded files of different type and saw the new UI. The same UI loaded
when reloading the page.

Deleting the entry worked properly. So did renaming the text.

Screenshots

reviewboard/templates/reviews/review_request_box.html (Diff revision 1)

Can you put the image inside the link? I could see people wanting to click on it, given its location.

Change Summary:

Made the icon clickable.

Diff:

Revision 2 (+180 -85)

Show changes

	reviewboard/htdocs/media/rb/css/reviews.css
	reviewboard/htdocs/media/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_request_box.html
	reviewboard/templates/reviews/review_request_dlgs.html
	reviewboard/templates/reviews/screenshot_detail.html

Ship it!

The image doesn't have a border around it now, right?

chipx86 May 26, 2011, 5 p.m.
```
What border?
```

david May 26, 2011, 5:01 p.m.

The one that images often have when they're inside an <a>. I'll assume that's a "no".

chipx86 May 26, 2011, 5:11 p.m.

Oh, that's a no. They're actually disabled globally.