Style fix for Issue 1903 : New Label Styles

Review Request #2366 — Created May 17, 2011 and submitted

vladikoff
Review Board
reviewboard
Adding an additional class to style the [Discarded] label. Future styling possible for other labels with this dynamic class. 

Mentioned in issue 1903 : http://code.google.com/p/reviewboard/issues/detail?id=1903
Local Server Testing with Sample Data
VL
david
  1. 
      
  2. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
     
    Just using the "label" field here won't survive localization. I'd suggest adding another parameter to __labeled_summary which is the class to add and then passing that through unadorned.
    
    We can also generalize the .draftlabel class. There are three kinds of labels we add on the summary: draft, submitted, and discarded. Each of these could have its own CSS class (.label-draft, .label-discarded, .label-submitted).
  3. 
      
VL
david
  1. Just one more change:
  2. reviewboard/reviews/datagrids.py (Diff revision 2)
     
     
    This one needs to be updated too, plus you need to add a label-submitted entry to the CSS file.
  3. 
      
VL
Review request changed

Change Summary:

Updated with new label classes and colors. 

Diff:

Revision 3 (+15 -7)

Show changes

Screenshots:

-Example
+Labels
david
  1. Looks good. Pushing to master as 6d00cad.
  2. 
      
LI
  1. Ship It!
  2. 
      
LI
  1. 
      
  2. 
      
Loading...