The main concept of installer script.

Ship It!

Babak:

Hey, just a few general comments here:

1)  For future reference:  in most if not all cases, a "Ship-it" on a review means that someone else has given your contribution a thumbs up for landing / merging.  Giving yourself a ship-it...doesn't make a whole lot of sense.

2)  A good rule of thumb is to run your code through the PEP8 script (http://pypi.python.org/pypi/pep8) before submitting it.  This will ensure that it conforms to PEP8, which Review Board tries to adhere to (there are some exceptions in the code.  You don't need to correct violations in code you didn't add, but don't add new code that violates PEP8).

3)  If you have a list of things, like imports, or CSS parameters, but them in alphabetical order for easier searching.

You can find my more specific comments below.

Thanks,

-Mike

alphabetize

No space needed here

whitespace (henceforth referred to as "ws")

ws

ws

ws

A few comments:

1)  You know, I can see this becoming a big ball of conditionals.  Maybe something akin to the Factory pattern for each OS might be cleaner.

2)  Try not to put magic strings around.  It's better to define a string as a constant somewhere, and then just use the constant in place of the string.