Support attached comment for reviews submitions
Review Request #2338 — Created May 5, 2011 and submitted — Latest diff uploaded
* Added supported for close comment. After a review request is marked "submitted" or "discarded", submitter can add text to describe the submission. * Fixed a bug that submitting review request will trash unpublished draft. Now, a confirm windows will popup to remind users. * Showed submission date for submitted review request under summary. TODO: * Maybe rbtools support is needed.
Manually tested and unit tested. The unit test output attached. Some failed and errors happened, but it looks like caused by windows environment. In fact, the output is the same before and after this commit.
Screenshots
Running dependency checks (set DEBUG=False to turn this off)...
Warning: p4python (>=07.3) not found. Perforce integration will not work.
Warning: hg not found. Mercurial integration will not work.
Warning: bzrlib not found. Bazaar integration will not work.
Warning: PyLucene (with JCC) is required to enable search. See the documentation for instructions.
Warning: mtn binary not found. Monotone integration will not work.
Please see http://www.reviewboard.org/docs/manual/dev/admin/
for help setting up Review Board.
C:\Python25\lib\site-packages\Crypto\Util\randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken
RandomPool_DeprecationWarning)
Testing User.is_profile_public with private profiles. ... ok
Testing User.is_profile_public with public profiles. ... ok
Testing check_updates_required with valid configuration ... ok
Testing check_updates_required with a
Diff Revision 3
This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.
orig
1
2
3
4
| reviewboard/htdocs/media/rb/js/datastore.js |
|---|
| reviewboard/htdocs/media/rb/js/reviews.js |
|---|
| reviewboard/reviews/models.py |
|---|
| reviewboard/reviews/views.py |
|---|
| reviewboard/templates/reviews/review_header.html |
|---|
| reviewboard/templates/reviews/review_request_box.html |
|---|
| reviewboard/webapi/resources.py |
|---|
| reviewboard/webapi/tests.py |
|---|