I'd like to be able to attach a comment when clicking [Submitted] to
close out a review. I generally want to tag the review with the
changeset number that checked it in.
Currently, pending review edits are committed when you click
[Submitted]. This technically satisfies my wish, but it's rather
counter-intuitive. Also, it sends email to reviewers. That's not 100%
bad but should be a per-user option with values: { never [default];
only on reviews I was requested to review; only on reviews I've actually
commented on }.
UI: clicking [Submitted] pops up a comment edit window; if you [Publish]
immediately, it goes in with no comment; if you type a comment, it
appears in the list of review comments just like other comments, but
visually marked (e.g. "[Submitted]" in the header line).
[ It would be nice to integrate this with bug tracking & version control
systems so submission & changeset info could be captured automatically.
But this would be incredibly difficult even if reviewboard was tightly
bound to a single bug tracker & vcs: was it closed because this fix was
checked in, a fix elsewhere pinched off this code path, we decided it
wasn't a bug or wasn't important? So this is useless wishlist stuff. ]