Add local_site_name parameters to most sshutils functions.

Review Request #2327 — Created May 1, 2011 and submitted

Information

Review Board
master

Reviewers

Add local_site_name parameters to most sshutils functions.

sshutils now knows how to factor in LocalSites when figuring out which
ssh configuration and keys to use. A LocalSite's configuration lives in
~/.ssh/<local_site_name>/.

As part of this, I've better cleaned up the path determination for getting
the .ssh directory. In some cases, we assumed ".ssh", and in others we checked
for "ssh". We also were using Unix-style paths everywhere. Now we check
more carefully and use os.path.join.
Unit tests passed.

Tested this along with my upcoming pending changes, and they work.
david
  1. 
      
  2. reviewboard/scmtools/sshutils.py (Diff revision 1)
     
     
    Can you make this use super() instead?
    1. Can't yet. It won't work with Python 2.4.
    2. Can't yet. It won't work with Python 2.4. Exceptions are old-style objects.
    3. Good point. Fix the double-comment issue and then ship it :)
  3.