-
-
reviewboard/templates/reviews/review_draft_inline_form.html (Diff revision 1) This should be indented 4 spaces, not 2
-
reviewboard/templates/reviews/review_draft_inline_form.html (Diff revision 1) This should be indented 4 spaces, not 2.
Fix saving comments on the review form.
Review Request #2322 — Created April 27, 2011 and submitted
Fix saving comments on the review form. The review form was broken, due to the move to the new web API in the web UI. We were using the old style of creating datastore functions, and ended up not having valid IDs to pass. Now we use the proper create* and ready() functions to make sure we have valid objects we can use. Some of this is a bit request-heavy now, and a bit ugly. I'm planning a rewrite of this form before 1.6 that will make life much nicer and greatly improve the experience with large reviews.
Tested saving both screenshot comments and diff comments. The values persisted.