Correct status in mail when summary was changed

 






 

 


  Review Request #2288
  —
  Created April 14, 2011 and submitted

 


















 

  

   Information

  





 
 

  philipp
 









 
 

  Review Board
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
We were confused by the notification mails when a review summary was changed. In such a case the HTML mail states that the description was changed. I checked the mail templates and found that this behavior was explicitly implemented. However, I changed it to my needs and the mails now clearly indicate  whether summary or description is changed. The summary is only included if there is a change in summary. 

 








  


 
 

  

 







 









 





  







 

  
Screenshots

  
 



 









 






  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Mind showing a screenshot of an HTML e-mail after this change?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    





    
    This looks like too many blank lines.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      True. Is fixed in new diff.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    





    
    Width of dashes should match the text.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Fixed in new diff.
      
 
      

      2. 


 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 

   
    
    
    





    
    No spaces inside {{..}}

(I know we have that below -- it's wrong.)
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Fixed here and below.
      
 
      

      2. 


 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   





 PH





   

   

  

 



 















 



 

  

   





 PH





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  








 
Change Summary:

 
applied all proposals





 



  

   
Diff:

   
    
 Revision 2 (+20 -3)
Show changes
 
    reviewboard/templates/notifications/review_request_email.txt 
    reviewboard/templates/notifications/review_request_email.html 
 

   		
  



 










  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Thanks, committed to master (1a2d809)
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...