Add optional enable_highlighting parameter in get_file_chunks_in_range

Review Request #2243 — Created April 5, 2011 and discarded

Information

Review Board

Reviewers

added optional parameter so that we can call this function and force the code chunk to have/not have highlighting surrounding it, despite the site configuration settings.

 
Description From Last Updated

jjjkkklll

HA hansnana
david
  1. 
      
  2. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     
    This should be enable_highlighting=True
  3. reviewboard/diffviewer/diffutils.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
    If you change enable_highlighting to be a boolean, then this can be:
    
    files = get_diff_files(
        filediff.diffset,
        filediff,
        interdiffset,
        enable_highlighting and get_enable_highlighting(context['user']))
    context[key] = files
  4. 
      
KA
HA
  1. 
      
  2. reviewboard/diffviewer/diffutils.py (Diff revision 2)
     
     
    jjjkkklll
    1. Hans:
      
      This is a production instance of Review Board, and not for testing.  Please use http://demo.reviewboard.org for tests.
      
      Thanks,
      
      -Mike
  3. 
      
KA
Review request changed

Status: Discarded

Loading...