Summary

Add optional enable_highlighting parameter in get_file_chunks_in_range

Review Request #2243 — Created April 5, 2011 and discarded Sept. 29, 2012, 12:51 p.m.

Information

Owner

kamlani

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

added optional parameter so that we can call this function and force the code chunk to have/not have highlighting surrounding it, despite the site configuration settings.

Testing Done

Issues

Description	From	Last Updated
jjjkkklll	HA hansnana	Jan. 27, 2012, 5:17 p.m.

reviewboard/diffviewer/diffutils.py (Diff revision 1)
```
This should be enable_highlighting=True
```

reviewboard/diffviewer/diffutils.py (Diff revision 1)

If you change enable_highlighting to be a boolean, then this can be:

files = get_diff_files(
    filediff.diffset,
    filediff,
    interdiffset,
    enable_highlighting and get_enable_highlighting(context['user']))
context[key] = files

Diff:

Revision 2 (+5 -3)

Show changes

reviewboard/diffviewer/diffutils.py

Fix it!

reviewboard/diffviewer/diffutils.py (Diff revision 2)

An issue was opened. Show all issues

jjjkkklll

mike_conley Jan. 28, 2012, 1:40 a.m.

Hans:

This is a production instance of Review Board, and not for testing.  Please use http://demo.reviewboard.org for tests.

Thanks,

-Mike

Status:: Discarded