Summary

Django 1.3 compatibility fix - no 'insecure' parameter in Django 1.3 version

Review Request #2236 — Created April 5, 2011 and discarded

Information

Owner

jan.koprowski

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix error with ReviewBoard passing 'insecure' option to development web-server causing error:

serve() got an unexpected keyword argument 'insecure'

Testing Done

reviewboard/urls.py (Diff revision 1)

I don't think this check works. If there's ever a version 2.0 of django, this will evaluate to True.

jan.koprowski April 5, 2011, 3:06 p.m.

Good point - thanks. I missed that. You are good reviewer :) You have this in blood :]

Change Summary:

Fix assumed issues with possible Django 2.x version

Diff:

Revision 2 (+1 -1)

Show changes

reviewboard/urls.py

Actually, insecure was only for Django 1.3 betas. They've since changed the model. So really, we don't actually want to set this flag anymore, regardless. I think we need something new for 1.3 and devel servers. Looking into it.