Make rbtools work with rb 1.5.1 with http basic auth

Review Request #2229 — Created April 1, 2011 and submitted

Information

RBTools

Reviewers

    Make rbtools postreview work with 1.5.1 with HTTP basic auth.
    The changes to make this work:
        * Allow auth retries when the URL has changed
        * Allow HTTP 401 to occur when getting root /api
Tested against internal review board install
HO
HO
chipx86
  1. So this seems to be about 1.5.1 specifically. Is any of this needed in newer versions? We don't support 1.5.1 anymore (just the latest 1.5.x), so if this is specific to 1.5.1, I'd prefer it stay in your own version until you're ready to upgrade.
    1. So we've upgraded to 1.5.5 and the issue still occures.
  2. rbtools/postreview.py (Diff revision 1)
     
     
     
     
    Blank line around blocks.
    
    So, blank line above and below "self._lasturl = args[0]"
  3. rbtools/postreview.py (Diff revision 1)
     
     
    Change this to "if e.http_status not in (401, 404):"
  4. rbtools/postreview.py (Diff revision 1)
     
     
     
    Blank line between these.
  5. 
      
HO
Review request changed
Change Summary:
Update change based on CR feedback.
david
  1. Committed with minor changes as ad6e1b8. Thanks!
  2.