Fix ordering of values in change descriptions.

Review Request #2216 — Created March 26, 2011 and submitted

Information

Review Board
master

Reviewers

Fix ordering of values in change descriptions.

Change descriptions would end up with values being in seemingly random orders.
Bug numbers, for example. This was due to converting to sets prematurely.
We were converting to sets in order to get the add/remove lists, but there
was no reason to using them in the old/new lists.
Unit tests passed.

Verified that the ordering is correct.

My other change description change depends on this in order to pass tests,
since it can't assume order otherwise.