read default REVIEWBOARD_URL, TARGET_GROUPS, TARGET_PEOPLE, SUBMIT_AS, PUBLISH, OPEN_BROWSER from config file

Review Request #2178 — Created March 3, 2011 and discarded

Information

RBTools

Reviewers

for bigger projects REVIEWBOARD_URL .reviewboardrc isn't all there could be. TARGET_GROUPS and TARGET_PEOPLE should be configurable with .reviewboardrc too. therefore i added everything with a fallback value.

commandline parameters still override .reviewboardrc values.

read default REVIEWBOARD_URL, TARGET_GROUPS, TARGET_PEOPLE, SUBMIT_AS, PUBLISH, OPEN_BROWSER from config file as it is done for other params.
created a reviewrequest with TARGET_GROUPS on git.reviewboard.kde.org, did what it should do.
FR
chipx86
  1. Sorry for sitting on this so long. This is a great change and we're going to incorporate a version of it, but with a bit of a rewrite due to the direction we're moving in RBTools. These flags, plus others, will all be supported in 0.4. Thanks!
    1. Thank you for getting this into 0.4! :)
  2. 
      
FR
Review request changed
Status:
Discarded
Change Summary:
Replaced by /r/2919, which implements these and more with the new API.