bugfix 1571
Review Request #2058 — Created Jan. 22, 2011 and submitted
| Information | |
|---|---|
| dorothyk | |
| Review Board | |
| 1571 | |
| Reviewers | |
| reviewboard | |
On a "New Review Request" page, the text fields for paths and filenames are too short. By setting the widths of related table and classes width 100% to fit the screen, and the size of the fileinput to be long enough under 800x600, they become longer. It works well in firefox (800x600) and Chromium. Need to be tested in IE and safari as well as for SVN repository.
-
-
.reviewboardrc (Diff revision 2) This shouldn't be here. You'll want to edit your commits and remove this.
-
reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 2) Space before { Same with the other rules. -
reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 2) Space after : Same with the other rules.
DO
Change Summary:
Edited the description.
Description: |
|
|---|
-
-
reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 3) You can combine these, like: #new-review-table, #id_basedir, #id_diff_path, #id_parent_diff_path { width: 100%; }
-
So I applied this and fixed the issue below, but I'm not seeing the 100% width on Firefox. Should I be?
-
reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 4) This isn't the same ID as in the template. Instead of a custom ID, though, you could probably just do ".new-review-request table"
