bugfix 1571

Review Request #2058 — Created Jan. 22, 2011 and submitted

Information

Review Board

Reviewers

On a "New Review Request" page, the text fields for paths and filenames are too short.
By setting the widths of related table and classes width 100% to fit the screen, and the size of the fileinput to be long enough under 800x600,
they become longer.

It works well in firefox (800x600) and Chromium.
Need to be tested in IE and safari as well as for SVN repository.

 
DO
chipx86
  1. It'd be nice to edit the summary be self-descriptive. That way reviewers don't have to know about the bug report first.
    
    So this gives us the 100% width? What was preventing the width from being 100% in our earlier tests?
  2. .reviewboardrc (Diff revision 2)
     
     
    This shouldn't be here. You'll want to edit your commits and remove this.
  3. reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 2)
     
     
     
    Space before {
    
    Same with the other rules.
  4. reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 2)
     
     
     
    Space after :
    
    Same with the other rules.
  5. 
      
DO
DO
chipx86
  1. 
      
  2. reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    You can combine these, like:
    
    #new-review-table,
    #id_basedir,
    #id_diff_path,
    #id_parent_diff_path {
       width: 100%;
    }
  3. 
      
DO
chipx86
  1. So I applied this and fixed the issue below, but I'm not seeing the 100% width on Firefox. Should I be?
    1. It should be 100% width on Firefox under 800x600..
  2. This isn't the same ID as in the template.
    
    Instead of a custom ID, though, you could probably just do ".new-review-request table"
  3. 
      
DO
Review request changed
david
  1. Pushed to master as a5a493e. Thanks!
  2. 
      
AO
  1. 
      
  2.