Summary

bugfix 1571

Review Request #2058 — Created Jan. 22, 2011 and submitted

Information

Owner

dorothyk

Repository

Review Board

Branch

Bugs

1571

Depends On

Reviewers

Groups

reviewboard

People

Description

On a "New Review Request" page, the text fields for paths and filenames are too short.
By setting the widths of related table and classes width 100% to fit the screen, and the size of the fileinput to be long enough under 800x600,
they become longer.

It works well in firefox (800x600) and Chromium.
Need to be tested in IE and safari as well as for SVN repository.

Testing Done

Screenshots

firefox (1366x768)

chromium

firefox(800x600)

Change Summary:

resize it to work under 800x600 under firefox

Diff:

Revision 2 (+22 -5)

Show changes

	.reviewboardrc
	reviewboard/htdocs/media/rb/css/reviews.css
	reviewboard/reviews/forms.py
	reviewboard/templates/reviews/new_review_request.html

It'd be nice to edit the summary be self-descriptive. That way reviewers don't have to know about the bug report first.

So this gives us the 100% width? What was preventing the width from being 100% in our earlier tests?

.reviewboardrc (Diff revision 2)

This shouldn't be here. You'll want to edit your commits and remove this.

reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 2)
```
Space before {

Same with the other rules.
```
reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 2)
```
Space after :

Same with the other rules.
```

Change Summary:: Edited the description.
Description:: ~
Make the table to fit the screen size.
~ And resize the fileinput widget for longer path and filename.
~ It works well in Chrome but overflows when screensize is small under firefox.
~
On a "New Review Request" page, the text fields for paths and filenames are too short.
~ By setting the widths of related table and classes width 100% to fit the screen, and the size of the fileinput to be long enough under 800x600,
~ they become longer.
+
+
It works well in firefox (800x600) and Chromium.
Need to be tested in IE and safari as well as for SVN repository.

Change Summary:

Modified for code style.

Diff:

Revision 3 (+21 -4)

Show changes

	reviewboard/htdocs/media/rb/css/reviews.css
	reviewboard/reviews/forms.py
	reviewboard/templates/reviews/new_review_request.html

reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 3)

You can combine these, like:

#new-review-table,
#id_basedir,
#id_diff_path,
#id_parent_diff_path {
   width: 100%;
}

Diff:

Revision 4 (+11 -4)

Show changes

	reviewboard/htdocs/media/rb/css/reviews.css
	reviewboard/reviews/forms.py
	reviewboard/templates/reviews/new_review_request.html

So I applied this and fixed the issue below, but I'm not seeing the 100% width on Firefox. Should I be?

dorothyk Feb. 20, 2011, 3:27 a.m.

It should be 100% width on Firefox under 800x600..

reviewboard/htdocs/media/rb/css/reviews.css (Diff revision 4)

This isn't the same ID as in the template.

Instead of a custom ID, though, you could probably just do ".new-review-request table"

Diff:

Revision 5 (+10 -3)

Show changes

	reviewboard/htdocs/media/rb/css/reviews.css
	reviewboard/reviews/forms.py

Ship it!

```
Pushed to master as a5a493e. Thanks!
```

Ship it!

~		Make the table to fit the screen size.
~		And resize the fileinput widget for longer path and filename.
~		It works well in Chrome but overflows when screensize is small under firefox.
	~	On a "New Review Request" page, the text fields for paths and filenames are too short.
	~	By setting the widths of related table and classes width 100% to fit the screen, and the size of the fileinput to be long enough under 800x600,
	~	they become longer.
	+
	+	It works well in firefox (800x600) and Chromium.
		Need to be tested in IE and safari as well as for SVN repository.