Updated prefs to use a better method of condition checking

Review Request #2043 — Created Jan. 16, 2011 and submitted

Information

Review Board

Reviewers

Updated prefs to use a better method of condition checking


Updated issue 1233 to seek out the keyword "groups" rather than the keyword "li", it is figured that groups would have a much longer life span if elements are changed than 'li' would
Ran this with a new user when there were no groups in the db at all, and ran it with a new user when there were groups in the db.
SW
SW
chipx86
  1. 
      
  2. I think there's an easier way to do this.
    
    Try:
    
    {% if form.groups.choices %}
    
    Also, you probably want this around the "Groups" box below. The entire {% box %} area for "Which groups do you belong to ..."
  3. 
      
SW
Review request changed

Change Summary:

Fixed according to chris' comments.  Added a condition around the group box, and used the condition form.fields.groups.choices. Thanks to Mike for helping to find the location of choices.

Summary:

-Updated issue 1233 to seek out the keyword "groups" rather than the keyword "li"
+Updated prefs to use a better method of condition checking

Description:

  +

Updated prefs to use a better method of condition checking

  +
  +

  +
   

Updated issue 1233 to seek out the keyword "groups" rather than the keyword "li", it is figured that groups would have a much longer life span if elements are changed than 'li' would

Diff:

Revision 3 (+4)

Show changes

mike_conley
  1. Ship It!
  2. 
      
david
  1. Pushed to master as e9c1692. Thanks!
  2. 
      
Loading...