Summary

Updated prefs to use a better method of condition checking

Review Request #2043 — Created Jan. 16, 2011 and submitted

Information

Owner

sws587

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Updated prefs to use a better method of condition checking


Updated issue 1233 to seek out the keyword "groups" rather than the keyword "li", it is figured that groups would have a much longer life span if elements are changed than 'li' would

Testing Done

Ran this with a new user when there were no groups in the db at all, and ran it with a new user when there were groups in the db.

Summary:: Updated prefs.html to remove the 'must chose a group line' if no groups are present.
Attempt to resolve 1233: Updated prefs.html to remove the 'must chose a group line' if no groups are present.

Change Summary:

Updated this issue so that the keyword searched is "groups" rather than the "li", since its suspected that "groups" will be a longer lasting keyword. (ie: its possible that the return value of groups removes the list items in future versions, but the various id names all include the word "group" and its not too likely that those would be modified without drastic consequences to the remainder of the site).

Summary:

Attempt to resolve 1233: Updated prefs.html to remove the 'must chose a group line' if no groups are present.

Updated issue 1233 to seek out the keyword "groups" rather than the keyword "li"

Description:

~		Upated prefs.html to include a second condition statement checking if there is any list (li) value in the groups (indicating if there are any values or not). If there are no groups present then the line stating they must chose a group is removed.
	~	Updated issue 1233 to seek out the keyword "groups" rather than the keyword "li", it is figured that groups would have a much longer life span if elements are changed than 'li' would
-
-		Maybe not a perfect solution. When form.groups returns, if its
-		empty it returns a '<ul> </ul>' html string, I made use of the cut command
-		to aid in detecting <li>'s (that only exist if there was more content
-		in the groups than the empty <ul>'s). If the content of groups is ever
-		changed to not include the li tags this will be ineffective.
-
-		But my first attempt at Django & RB so comment away!

Diff:

Revision 2 (+2)

Show changes

reviewboard/templates/accounts/prefs.html

reviewboard/templates/accounts/prefs.html (Diff revision 2)

I think there's an easier way to do this.

Try:

{% if form.groups.choices %}

Also, you probably want this around the "Groups" box below. The entire {% box %} area for "Which groups do you belong to ..."