Make changes to the webui to use local-site APIs

Review Request #1998 — Created Dec. 14, 2010 and submitted


Review Board


Make changes to the webui to use local-site APIs

The webui wasn't calling into the correct API paths for things related to review
requests. I'm not entirely positive that I caught everything, but this seems to
have fixed screenshot upload and commenting, review commenting, diff commenting
and replies to all of the above.
Ran through a bunch of actions relating to an open, local-site-ed review request,
including creating reviews, comments, and replies.
  2. reviewboard/htdocs/media/rb/js/datastore.js (Diff revision 1)
    I wonder if instead of a prefix option, if we should define the path to the API instead. Instead of assuming SITE_ROOT + "api" or SITE_ROOT + prefix + "api", we should just have a gApiPath that we use. Then we don't have to pass prefix around the place. I think?
    1. That doesn't really help us too much when there's no review request. But then again, I don't know that we make any API calls without a review request. I'd prefer to leave this as-is for now, and figure out a more generic solution when we need it.
  3. Too many '{' on the last {% endif %}
Review request changed
  1. Long-term, I'd like to have some central point specifying the root of the API, but not important right now.