Fish Trophy

david got a fish trophy!

Add LocalSite rooting for the ReviewResource.

Review Request #1991 — Created Dec. 11, 2010 and submitted

Information

Review Board
master

Reviewers

Add LocalSite rooting for the ReviewResource.

This change adds the local site namespacing and unit tests for reviews and draft
reviews.
Unit tests pass.
chipx86
  1. 
      
  2. reviewboard/webapi/resources.py (Diff revision 1)
     
     
     
     
     
     
    I guess this is needed because of the whole reverse() not doing the right thing?
    
    Instead of hard-coding "reviews", can you use self.uri_name?
    1. Sure, that works.
      
      It's needed because review requests alternately use "id" or "local_id" as their object key.
  3. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    Same here.
  4. 
      
david
Review request changed
chipx86
  1. 
      
  2. 
      
Loading...