Summary

Add LocalSite rooting for the ReviewGroupResource

Review Request #1958 — Created Nov. 30, 2010 and submitted

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add LocalSite rooting for the ReviewGroupResource

This change adds namespacing and unit tests for the ReviewGroupResource and
ReviewGroupUserResource.

Testing Done

reviewboard/webapi/resources.py (Diff revision 1)

local_site_name can go in the argument list.

Does this work when local_site_name is None? Can't remember what Django does when the relation can't be resolved in this case. Want to make sure that the Group query works if local_site__name never matches anything.

david Nov. 30, 2010, 6:01 p.m.

The local_site__name relation will return None when name is None. I'll add it to the args list.

reviewboard/webapi/tests.py (Diff revision 1)

Can this use the new constant?

david Nov. 30, 2010, 6:06 p.m.

That constant was a class member of a different class, but I'll add one here too.

Diff:

Revision 2 (+53 -5)

Show changes

	reviewboard/webapi/resources.py
	reviewboard/webapi/tests.py

Ship it!