Summary

Add LocalSite rooting for the Repository resources.

Review Request #1956 — Created Nov. 29, 2010 and submitted

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Add LocalSite rooting for the Repository resources.

This change adds namespacing and unit tests for the RepositoryResource and
RepositoryInfoResource.

Testing Done

reviewboard/webapi/resources.py (Diff revision 1)

You should just be able to provide local_site_name=None in the argument list for the function.

david Nov. 30, 2010, 8:17 a.m.
```
Sure.
```

reviewboard/webapi/tests.py (Diff revision 1)

Can we maybe define a const somewhere for the tests so we don't have to repeat "local-site-1" everywhere?

david Nov. 30, 2010, 8:38 a.m.
```
Sure, I'll just add a class member.
```

reviewboard/webapi/tests.py (Diff revision 1)

This feels unsafe. If there's a particular Repository we're looking for, let's first fetch the Repository and then use the pk.

david Nov. 30, 2010, 8:40 a.m.

Okay. It's still kind of arbitrary (since it's relying on knowledge of what's in the test fixtures), but I guess the name is less likely to change.

reviewboard/webapi/tests.py (Diff revision 1)
```
Same here with the repository ID.
```
1. david Nov. 30, 2010, 8:40 a.m.
  Okay.

Diff:

Revision 2 (+44 -3)

Show changes

	reviewboard/webapi/resources.py
	reviewboard/webapi/tests.py

reviewboard/webapi/resources.py (Diff revision 2)

Remind me if I brought this up on another review request and there's an answer, because I really can't remember right now...

If the name passed doesn't exist, should this be defaulting to the main site? Or should it cause a 404? Or are we already getting that from the decorators?

If we're good, then ship it.

david Nov. 30, 2010, 2:09 p.m.

We're getting that from the decorators. In fact, the decorator works such that none of this code will ever even execute.

Ship it!