Change Summary:
Fixes for the admin UI, and specifically only allow for invite-only groups in the Repository review group list (as public ones would defeat the purpose).
Diff: |
Revision 2 (+199 -3) |
|---|
Add support for access control on repositories.
Review Request #1890 — Created Nov. 2, 2010 and submitted
Add support for access control on repositories. This provides the ability to lock down a repository and make it private so that only those users who are explicitly granted access (directly or through an invite-only review group) can view review requests on the repository. This ties into the existing is_accessible_by checks to guarantee the new logic will work in the API and the UI. Access is determined per-repository, rather than by a path within a repository. Any user with access to a repository likely has access to the entire thing. This may not always be true, in that some advanced repository setups may have ACLs that work on a per-path basis. However, for now we are not supporting this. It can be added later if there is need for it, possibly through an extension that augments the access determination to check the ACLs on the repository.
Passes the unit tests and works in the UI.
-
-
reviewboard/reviews/models.py (Diff revision 2) Hmm. While this function is good, I'm really starting to think we should we should also have a special QuerySet type returned by our manager that has an accessible_by() filter.
-