issue 1387: Review ID # should be obvious and visible in HTML content of Review
Review Request #1826 — Created Oct. 14, 2010 and submitted
It is small patch but its a start for me. Someone requested the review id visible and available as a link. I tried out a few locations and I think this is the nice one. Looking forward to hearing your opinion. Please review. Link: http://code.google.com/p/reviewboard/issues/detail?id=1387 Cheers, cristian
patch too small
Screenshots
-
Thanks for the patch! Generally with a person's first few patches, we review fairly heavily, since there's a lot of things people may not be familiar wiht in terms of Django, our codebase, and our coding style, so I'll point them all out here.
-
reviewboard/templates/reviews/review_request_box.html (Diff revision 1) There's a terminology difference here. It really should be "Review Request" and not "Review". Also, variables should be {{foo}} rather than {{ foo }} or {{ foo}}. I realize that the we have {{ lastupdated}} in there already, but that's a typo. One more thing, which is just one of those things that you learn as you learn Django. Rather than hard-coding paths to pages, you should be using {{review_request.get_absolute_url}}. This will return the proper path even if the page moves locations (or if it's installed in a subdirectory).
ME
Change Summary:
updated according to the suggestions. btw thank you very much for the pointers and in the future any advice you have please give it. its a really fast way to learn!
Diff: |
Revision 2 (+1 -1) |
---|
-
-
reviewboard/templates/reviews/review_request_box.html (Diff revision 2) Hey - there's still some terminology confusion here: reviewid should be something like reviewrequestid, and reviewurl should be something like reviewrequesturl. Or maybe review_request_id and review_request_url for readability.
ME
Change Summary:
Sorry for the late patch. I am having some trouble installing reviewboard on my new machine but it should be sorted out soon. Also I had to prepare a presentation for openSuse conference in Nuremberg. (pretty happy about it.. I will stop bragging now. sorry) Thank you for all the comments on such a small patch. It actually helps.
Diff: |
Revision 3 (+1 -1) |
---|
-
Thanks again for the patch! One last tiny suggestion - purely for code beautification. -Mike
-
reviewboard/templates/reviews/review_request_box.html (Diff revision 3) Last suggestion: Only 1 space between "blocktrans" and "with", and then maybe put the contents of the block on different lines, like: {% blocktrans with ...yaddayadda %} Review Request <a href="yadda yadda"... {% endblocktrans %} That's all I've got though. Everything else looks OK. Once this is done, you've got my ship-it. :D