• 
      

    issue 1387: Review ID # should be obvious and visible in HTML content of Review

    Review Request #1826 — Created Oct. 14, 2010 and submitted

    Information

    Review Board

    Reviewers

    It is small patch but its a start for me.
    
    Someone requested the review id visible and available as a link. I tried out a few locations and I think this is the nice one. Looking forward to hearing your opinion.
    
    Please review.
    
    Link: http://code.google.com/p/reviewboard/issues/detail?id=1387
    
    Cheers,
    cristian
    patch too small
    ME
    1. 
        
    2. this should outline my huge change :)
    3. 
        
    chipx86
    1. Thanks for the patch! Generally with a person's first few patches, we review fairly heavily, since there's a lot of things people may not be familiar wiht in terms of Django, our codebase, and our coding style, so I'll point them all out here.
    2. There's a terminology difference here. It really should be "Review Request" and not "Review".
      
      Also, variables should be {{foo}} rather than {{ foo }} or {{ foo}}. I realize that the we have {{ lastupdated}} in there already, but that's a typo.
      
      One more thing, which is just one of those things that you learn as you learn Django. Rather than hard-coding paths to pages, you should be using {{review_request.get_absolute_url}}. This will return the proper path even if the page moves locations (or if it's installed in a subdirectory).
    3. 
        
    ME
    mike_conley
    1. 
        
    2. Hey - there's still some terminology confusion here:
      
      reviewid should be something like 
      reviewrequestid, and reviewurl should be something like reviewrequesturl.
      
      Or maybe review_request_id and review_request_url for readability.
    3. 
        
    ME
    mike_conley
    1. Thanks again for the patch!
      
      One last tiny suggestion - purely for code beautification.
      
      -Mike
    2. Last suggestion:
      
      Only 1 space between "blocktrans" and "with", and then maybe put the contents of the block on different lines, like:
      
      {% blocktrans with ...yaddayadda %}
        Review Request <a href="yadda yadda"...
      {% endblocktrans %}
      
      That's all I've got though. Everything else looks OK.  Once this is done, you've got my ship-it.  :D
    3. 
        
    ME
    Review request changed
    mike_conley
    1. Looks good to me!  Thanks,
      
      -Mike
      1. Ok great! Happy to hear that. How do I ship it? Fork the github repo commit the changes and wait for you guys to cheery pick them in?
      2. I just committed it.  :)  Thanks!
    2.