Fix post-review for bare hostnames

 






 

 


  Review Request #1754
  —
  Created Aug. 31, 2010 and submitted

 


















 

  

   Information

  





 
 

  coderanger
 









 
 

  RBTools
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
cookielib automatically appends .local to any hostname with no '.'s, presumably because Mozilla does the same. This breaks the cookie lookup for something like http://reviews/.

 








  


 
 

  
Been using this internally for some time now.

 







 









 





  








 









 






  

 








 














 





 

  

   





 DJ





   

   







  

 



 

  


   

   

    
 
djs


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Now I know why it doesn't work for local domains.

Looks like there is a reason behind it:
http://www.ietf.org/rfc/rfc2965.txt
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks good. Committed to master as rf59e732. Thanks!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...